How does Rapid Review notice that a finding was fixed?
On every push, Rapid Review checks the findings that earlier pushes raised and judges whether this push addressed each one. It looks at the whole push, so a fix made in another file counts. The check’s summary opens with a line such as “2 of 3 earlier findings addressed, 1 open, no new findings.” Fixed findings are also listed under “Fixed since the last review”. “Fixed” is Rapid Review’s own reading of the push, not a person’s confirmation.What does “Looks fixed in” mean?
When a push fixes a finding that was posted as an inline comment, Rapid Review replies “Looks fixed in abc1234.” in its thread, with the commit, and resolves the thread. A finding that was listed in the review’s text, rather than posted as a comment, has its entry struck through with “Looks fixed in abc1234.”Can a fixed finding come back?
A finding resolved as fixed isn’t raised again while it stays fixed, even if the reviewer reports it again. If the problem comes back after it was gone, for example after a revert, Rapid Review raises it again as a new finding.Why does a fixed finding still show as open?
A few things keep a finding open:- Rapid Review couldn’t check it. For example, GitHub didn’t show every change since the finding was raised. The check says how many earlier findings stay open unchecked.
- GitHub didn’t let Rapid Review resolve the thread. The thread then stays open, and the check says why. The next push tries again.
- GitHub didn’t let Rapid Review edit the review’s text. The entry then stays as it was, and the check says why.